This repository has been archived by the owner on Sep 10, 2022. It is now read-only.
use the ipnet.PSK instead of the ipnet.Protector for private networks #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
Stebalien
approved these changes
Feb 27, 2020
| if u.Protector != nil { | ||
| pconn, err := u.Protector.Protect(conn) | ||
| if u.PSK != nil { | ||
| pconn, err := pnet.NewProtectedConn(u.PSK, conn) |
There was a problem hiding this comment.
future: We may want to eventually expose this as a "Protect" function so transports can choose which pieces of the upgrader they want to use.
Stebalien
approved these changes
Mar 3, 2020
Stebalien
force-pushed
the
generalize-private-network
branch
from
41e16ad
to
593ceaf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See libp2p/go-libp2p-core#118 for the interface change.
Looks like we'll need to update go.mod before merging this PR (after releasing a new version of go-libp2p-pnet containing libp2p/go-libp2p-pnet#32).
Tracking issue: libp2p/go-libp2p#795.