move go-ws-transport here #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes websocket interop with js-ipfs
fix: use binary frames instead of text frames
feat: upgrade to use gorilla/websocket
fix reading from conn and addresses
1. Ensure we only close the connection once. Especially, don't call the done function multiple times and/or concurrently. 2. Call WriteControl instead of WriteMessage in Close. WriteControl is thread-safe, WriteMessage isn't. Also, this sets a 100ms deadline on gracefully closing connections.
Just to be thorough.
(make @whyrusleeping happy)
Make close thread safe
sync: update CI config files
remove deprecated type
chore: update go-libp2p-transport-upgrader and go-libp2p-core
use the transport.Upgrader interface
use the resource manager
add support for wss dialing
add support for listening on /wss addresses
vyzo
reviewed
Apr 22, 2022
Comment on lines
+26
to
+27
| csms "github.com/libp2p/go-conn-security-multistream" | ||
| mplex "github.com/libp2p/go-libp2p-mplex" |
There was a problem hiding this comment.
we should probably wait for these to be moved first.
There was a problem hiding this comment.
Why? go-libp2p depending on external repos is ok (the other way around would not).
There was a problem hiding this comment.
sure, but we'll have to remember to fix it!
There was a problem hiding this comment.
Of course. I do a sed for the import path every time I move a repo.
vyzo
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.