move go-libp2p-mplex here #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add support for the new Reset method.
remove conn.Serve
feat: update stream interfaces
change OpenStream to accept a context
update go-mplex, use the context passed to OpenStream
marten-seemann
force-pushed
the
merge-mplex
branch
2 times, most recently
from
ed6a9b5
to
d6a12cb
Compare
Stebalien
approved these changes
Apr 25, 2022
Stebalien
reviewed
Apr 25, 2022
| @@ -15,6 +15,8 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| mplex "github.com/libp2p/go-libp2p/p2p/muxer/mplex" | |||
There was a problem hiding this comment.
The package is named peerstream_multiplex, so I think we do.
There was a problem hiding this comment.
So, can we, like, fix that. Now?
There was a problem hiding this comment.
Sure. We should probably do the same for yamux.
marten-seemann
force-pushed
the
merge-mplex
branch
from
ac02b5c
to
9034260
Compare
marten-seemann
force-pushed
the
merge-mplex
branch
from
9034260
to
663cf70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.