merge the transport test suite from go-libp2p-testing here #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate test utilities, harnesses and suites (#1)
SubtestStress is exposed but it was not possible to build a working opt parameters.
pass contexts to OpenStream in tests
Defer closing stream for reading
Run `go mod tidy` Resolve staticcheck issues: - SA2002 `t.Fatal` must be called in the same goroutine as the test - U1000 unused struct - ST1005 error string should not be capitalized The `go vet` issues were the same as the ones reported by `saticcheck`. Relates to: - https://github.com/orgs/ipfs/projects/12#card-58209321
Address `go vet` and `saticcheck` issues
fix: cleanup transport suite
We don't close the connection before the echo hasn't returned, but echo won't return before AcceptStream has returned an error, which only happens when the connection is closed.
fix deadlock in the transport's serve function
add mocks for the resource manager
…2p/transport/testsuite
marten-seemann
force-pushed
the
merge-testsuite-transports
branch
from
f8a43fc
to
64cfca6
Compare
Closed
MarcoPolo
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1187.