Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swarm: move back off handling outside worker loop #2414

Closed
wants to merge 3 commits into from

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Jul 9, 2023

part of #2380

Depends on #2460

Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewing the second commit, as the first one has already been merged in #2416.

p2p/net/swarm/swarm_dial.go Outdated Show resolved Hide resolved
p2p/net/swarm/swarm_dial.go Outdated Show resolved Hide resolved
@sukunrt
Copy link
Member Author

sukunrt commented Aug 7, 2023

Closing this in favour of #2461

If we feel like doing this we can take this up after #2394

@sukunrt sukunrt closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants