Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial worker loop simplification. Move backoff filtering together with other filters. #2380

Open
sukunrt opened this issue Jun 19, 2023 · 0 comments
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@sukunrt
Copy link
Member

sukunrt commented Jun 19, 2023

This is a small simplification that I believe will fix tricky points in the worker loop.

We should do backoff filtering along with other address filtering in swarm.filterKnownUndialables
This will clean up some of the awkward error handling here and here

see #2320 (comment)
for how black hole detection can be made to work with this.

As a follow up I'd like to change the worker loop interface to just take the list of addresses to dial with the ranking and the address filtering and ranking all happens before the worker loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant