webrtc: add a test for establishing many connections #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
force-pushed
the
webrtc-fix
branch
4 times, most recently
from
ad84c06
to
8fcca64
Compare
sukunrt
commented
May 21, 2024
p2p/transport/webrtc/listener.go
Outdated
Comment on lines
332
to
333
| pc.OnConnectionStateChange(func(_ webrtc.PeerConnectionState) { | ||
| switch pc.ConnectionState() { |
There was a problem hiding this comment.
This works fine, but the change makes it better in case there are ordering issues for the callback. The callback does need to guarantee that we can access connection state.
There was a problem hiding this comment.
Apparently it doesn't work fine. pion/webrtc#2702 (comment)
So we do need this change.
sukunrt
force-pushed
the
webrtc-fix
branch
2 times, most recently
from
24f7760
to
5a485d6
Compare
MarcoPolo
reviewed
May 28, 2024
| return | ||
| } | ||
| s.Write(b[:]) | ||
| s.Read(b[:]) // peer will close the connection after read |
There was a problem hiding this comment.
Should we expect an error here then?
sukunrt
force-pushed
the
webrtc-fix
branch
2 times, most recently
from
3c3731a
to
64836ad
Compare
sukunrt
changed the title
sukunrt
force-pushed
the
webrtc-fix
branch
2 times, most recently
from
22aa5d5
to
a611a26
Compare
sukunrt
force-pushed
the
webrtc-fix
branch
5 times, most recently
from
8ca8216
to
fdb80f5
Compare
sukunrt
force-pushed
the
webrtc-fix
branch
11 times, most recently
from
5649cab
to
e529aa9
Compare
sukunrt
force-pushed
the
webrtc-fix
branch
3 times, most recently
from
2ade25d
to
e30aab2
Compare
MarcoPolo
approved these changes
Jun 11, 2024
sukunrt
added a commit
that referenced
this pull request
Jun 12, 2024
Update pion/ice to include the fix for out of order ConnectionState update callbacks
sukunrt
added a commit
that referenced
this pull request
Jun 12, 2024
Update pion/ice to include the fix for out of order ConnectionState update callbacks
MarcoPolo
added a commit
that referenced
this pull request
Jun 12, 2024
* identify: Don't filter addr if remote is neither public nor private (#2820) Updates the filterAddrs logic to no-op if the address is neither public nor private. This fixes an issue in mocknet that assigns each node an address in the IPv6 discard prefix space. That doesn't interact well with this logic in identify. The issue mocknet hits is that it filters out all received listen addresses and then doesn't remember any address for the peer. * identify: fix bug in observed address handling (#2825) * identify: add test for observed address handling (#2828) This modifies TestObservedAddrManager to verify the fix in #2825 * libp2phttp: workaround for ResponseWriter's CloseNotifier (#2821) * libp2phttp: workaround for CloseNotifier * Add lintignore * circuitv2: improve voucher validation (#2826) * webrtc: fix ufrag prefix for dialing (#2832) * webrtc: add a test for establishing many connections (#2801) Update pion/ice to include the fix for out of order ConnectionState update callbacks * release v0.35.1 --------- Co-authored-by: Marco Munizaga <git@marcopolo.io> Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
MarcoPolo
pushed a commit
that referenced
this pull request
Jun 13, 2024
Update pion/ice to include the fix for out of order ConnectionState update callbacks
MarcoPolo
pushed a commit
that referenced
this pull request
Jun 13, 2024
Update pion/ice to include the fix for out of order ConnectionState update callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.