libp2phttp: workaround for ResponseWriter's CloseNotifier #2821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Jun 7, 2024
sukunrt
pushed a commit
that referenced
this pull request
Jun 12, 2024
* libp2phttp: workaround for CloseNotifier * Add lintignore
sukunrt
pushed a commit
that referenced
this pull request
Jun 12, 2024
* libp2phttp: workaround for CloseNotifier * Add lintignore
MarcoPolo
added a commit
that referenced
this pull request
Jun 12, 2024
* identify: Don't filter addr if remote is neither public nor private (#2820) Updates the filterAddrs logic to no-op if the address is neither public nor private. This fixes an issue in mocknet that assigns each node an address in the IPv6 discard prefix space. That doesn't interact well with this logic in identify. The issue mocknet hits is that it filters out all received listen addresses and then doesn't remember any address for the peer. * identify: fix bug in observed address handling (#2825) * identify: add test for observed address handling (#2828) This modifies TestObservedAddrManager to verify the fix in #2825 * libp2phttp: workaround for ResponseWriter's CloseNotifier (#2821) * libp2phttp: workaround for CloseNotifier * Add lintignore * circuitv2: improve voucher validation (#2826) * webrtc: fix ufrag prefix for dialing (#2832) * webrtc: add a test for establishing many connections (#2801) Update pion/ice to include the fix for out of order ConnectionState update callbacks * release v0.35.1 --------- Co-authored-by: Marco Munizaga <git@marcopolo.io> Co-authored-by: Ivan Shvedunov <ivan4th@users.noreply.github.com>
MarcoPolo
added a commit
that referenced
this pull request
Jun 13, 2024
* libp2phttp: workaround for CloseNotifier * Add lintignore
MarcoPolo
added a commit
that referenced
this pull request
Jun 13, 2024
* libp2phttp: workaround for CloseNotifier * Add lintignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseWriter implements a deprecated
CloseNotifierinterface. The implementation considers any error during a read an indication that the whole connection is closed. One of these errors is EOF.When we do HTTP over streams, it's normal for an EOF to happen after reading the request (in fact, it's recommended in the spec).
The workaround here is to ignore EOF errors on read when it's a stream we accept a stream (Listener side). This should be fine since we know how to read a full request (doesn't rely on EOF) and if the stream is closed writing will fail