constructor: allow nil options #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
5 tasks
raulk
approved these changes
Apr 18, 2019
| var optsRun []int | ||
| optcount := 0 | ||
| newOpt := func() Option { | ||
| index := optcount |
There was a problem hiding this comment.
nit: possibly remove the index assignment by incrementing optcount in a defer statement?
There was a problem hiding this comment.
Ah, wait, no. We need to capture the current value.
This can make it significantly easier to configure libp2p with optional options.
Stebalien
force-pushed
the
feat/nil-option
branch
from
13cd715
to
cff9cb5
Compare
bigs
suggested changes
Apr 18, 2019
| if err := cfg.Apply(newOpt(), nil, ChainOptions(newOpt(), newOpt(), ChainOptions(), ChainOptions(nil, newOpt()))); err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| if optcount != len(optsRun) { |
There was a problem hiding this comment.
let's compare against a constant here, i.e. 4
| if optcount != len(optsRun) { | ||
| t.Errorf("expected to have handled %d options, handled %d", optcount, len(optsRun)) | ||
| } | ||
| for i, x := range optsRun { |
There was a problem hiding this comment.
if this is meant to test ordering, definitely drop a comment so future programmers understand the behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can make it significantly easier to configure libp2p with optional options.