chore: update sockaddr to fix build #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CircleCI scripts check builds on a ton of platforms and have better linting.
willscott
approved these changes
Mar 31, 2020
|
Test failure: #8. Merging because it's not actually related to this patch. |
|
the linux impl is failing to instantiate on circle: it looks like in circle the call to |
|
that code is unchanged from what's in gopacket. It's probably something to fail softer on in order to be happier running in situations without full access to the routing table/interfaces on the machine. |
|
I think we need to relax the restriction on all distros. Links may be in-order, but you can definitely delete links. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.