Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We shouldn't make assumptions about interface indices #8

Closed
Stebalien opened this issue Mar 31, 2020 · 2 comments · Fixed by #9
Closed

We shouldn't make assumptions about interface indices #8

Stebalien opened this issue Mar 31, 2020 · 2 comments · Fixed by #9
Assignees

Comments

@Stebalien
Copy link
Member

    TestRoute: netroute_test.go:12: out of order iface 1 = {6436 1500 eth0 02:42:ac:1c:00:03 up|broadcast|multicast}
@willscott
Copy link
Contributor

We may not have the privileges to learn all of the local interfaces and addresses - e.g. when we're running in a container. In these cases, it seems best to operate on the assumption that our only local interface addresses are the ones we can see, and if we end up routing to other addresses held on the local machine they'll end up looking the same as other lan-local routes where no other gateway intervenes.

willscott added a commit that referenced this issue Mar 31, 2020
willscott added a commit that referenced this issue Mar 31, 2020
@Stebalien
Copy link
Member Author

Links may be in-order, but you can definitely delete links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants