-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove full iface access assumption [linux/bsd] #9
Conversation
linux/bsd fix #8
07f49c3
to
ec875c9
Compare
1a7d09e
to
b22034c
Compare
b22034c
to
1e19d3d
Compare
Ok, well, upgrading something along the way has exposed the actual error. We're getting an index out of bounds error. |
|
We probably need to use a map instead of an array. |
be569ad
to
d8d75cf
Compare
tests passing is good. I'll merge & cut a release now to not block your downstream work. Take a look and confirm when you get a chance. |
@@ -23,6 +22,8 @@ import ( | |||
|
|||
func New() (routing.Router, error) { | |||
rtr := &router{} | |||
rtr.ifaces = make(map[int]net.Interface) | |||
rtr.addrs = make(map[int]ipAddrs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: We should probably pre-allocate these.
fix #8