This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: apply message size limit before decoding message #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
fix/apply-size-limit-during-decode
branch
from
fe0fd5b
to
f5ec195
Compare
If we apply the message size limit after decoding the message it's too late as we've already processed the bad message. Instead, if the buffer full of unprocessed messages grows to be large than the max message size (e.g. we have not recieved a complete message under the size limit), throw an error which will cause the stream to be reset.
achingbrain
force-pushed
the
fix/apply-size-limit-during-decode
branch
from
f5ec195
to
21a8f59
Compare
|
@achingbrain Is something missing from this PR? I only see you've added constant |
|
Hmm, weird - should be good now. |
mpetrunic
approved these changes
Nov 23, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 24, 2022
## [7.0.5](v7.0.4...v7.0.5) (2022-11-24) ### Bug Fixes * apply message size limit before decoding message ([#231](#231)) ([279ad47](279ad47)) * limit unprocessed message queue size separately to message size ([#234](#234)) ([2297856](2297856)) * yield single buffers ([#233](#233)) ([31d3938](31d3938))
|
🎉 This PR is included in version 7.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we apply the message size limit after decoding the message it's too late as we've already processed the bad message.
Instead, if the buffer full of unprocessed messages grows to be larger than the max message size (e.g. we have not received a complete message under the size limit), throw an error which will cause the stream to be reset.