Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: catch Multiplexer is destroyed error into callback #79

Merged
merged 2 commits into from
Jun 19, 2018
Merged

fix: catch Multiplexer is destroyed error into callback #79

merged 2 commits into from
Jun 19, 2018

Conversation

pgte
Copy link

@pgte pgte commented Jun 10, 2018

This prevents uncaught "Multiplexer is destroyed" exceptions from being thrown into the void.

@ghost ghost assigned pgte Jun 10, 2018
@ghost ghost added the status/in-progress In progress label Jun 10, 2018
@pgte pgte requested a review from daviddias June 10, 2018 10:01
daviddias
daviddias approved these changes Jun 19, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgte any chance of adding a test to this?

@pgte
Copy link
Author

pgte commented Jun 19, 2018

@diasdavid tests added in 2c0e827.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 219

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 79.208%
Totals Coverage Status
Change from base Build 217: 0.7%
Covered Lines: 327
Relevant Lines: 395
💛 - Coveralls

@daviddias
Copy link
Member

Going to squash to pass commit linting.

@daviddias daviddias merged commit b60205f into master Jun 19, 2018
@ghost ghost removed the status/in-progress In progress label Jun 19, 2018
@daviddias daviddias deleted the fix/multiplexer-destroyed-uncaught branch June 19, 2018 11:13
@daviddias daviddias mentioned this pull request Jun 19, 2018
Closed
dryajov pushed a commit that referenced this pull request Jun 19, 2018
@dryajov
fix: catch Multiplexer is destroyed error into callback (#79)
5e33c7f 
* fix: catch Multiplexer is destroyed error into callback

* basic muxer tests
@jacobheun jacobheun mentioned this pull request Jul 5, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@pgte pgte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pgte @coveralls @daviddias