This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat!: add metrics #223
Merged
feat!: add metrics #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses new metrics interface from libp2p/js-libp2p-interfaces#310 to report useful connection metrics. Similar to #217 but it adds the listening host/port to the metrics name to allow multiple TCP listeners to report metrics separately.
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 tasks
Closed
|
@achingbrain Using a variable metric name is a really bad idea this will break dashboards. Metric name should be constant and contain only Line 94 in 367d0ca I don't really see the point for splitting metrics for different ports. Once someone requests that feature we can add a label on the metric per address. But please do not do this now adding extra labels adds cost to metrics at no-one request |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses new metrics interface from libp2p/js-libp2p-interfaces#310 to report useful connection metrics.
Similar to #217 but it adds the listening host/port to the metrics name to allow multiple TCP listeners to report metrics separately.
BREAKING CHANGE: requires metrics interface v4