Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix syntax error in JS example in README #2123

Merged
merged 1 commit into from
Oct 4, 2023
Merged

docs: fix syntax error in JS example in README #2123

merged 1 commit into from
Oct 4, 2023

Conversation

scenaristeur
Copy link
Contributor

@scenaristeur scenaristeur commented Oct 4, 2023 •
edited by maschad
Loading

Title

docs: fix typo in Typescript example in README

Description

There is a syntax error in the import statements of the TS example.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@scenaristeur scenaristeur requested a review from a team as a code owner October 4, 2023 17:06
maschad
maschad approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maschad maschad changed the title Update GETTING_STARTED.md docs: fix typo in Typescript example in README Oct 4, 2023
@maschad maschad changed the title docs: fix typo in Typescript example in README docs: fix syntax error in JS example in README Oct 4, 2023
@maschad maschad merged commit 28794fe into libp2p:master Oct 4, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maschad maschad maschad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scenaristeur @maschad