fix: transport manager fault tolerance should include tolerance to transport listen fail #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ansport listen fail
lidel
approved these changes
Feb 25, 2021
There was a problem hiding this comment.
Tested this with ipfs-shipyard/ipfs-share-files#121 and works as expected:
@vasco-santos Is it possible to ship this as a patch release?
Merged
1 task
vasco-santos
deleted the
fix/transport-manager-fault-tolerance-should-include-tolerance-to-transport-listen-fail
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added a fault tolerance option to libp2p's transport manager, this only included a scenario where the provided multiaddrs were not compatible to the configured transport resulting in no listen multiaddrs used to create listeners in the transports.
This fault tolerance should also include tolerance for failure on trying to listen on multiaddrs that are compatible with the configured transport but the listen fails. This is specially important for remote listeners like relays and webrtc signal servers.
Context: ipfs-shipyard/ipfs-share-files#121