Fix the case when a stream is closed while still having buffered data for write #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ByteBufQueue tests * Writing exec path is always through fill/drain buffer * Adopt/fix existing tests * Add new test checking correct handling of negative sendWindowSize
… for write (due to zero sendWindow)
Nashatyrev
force-pushed
the
fix/close-after-buffered-write
branch
from
2161428
to
077815a
Compare
…ffered-write # Conflicts: # libp2p/src/main/kotlin/io/libp2p/mux/yamux/YamuxHandler.kt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Stream is locally closed for writing but there is some data buffered for writing still, the
YamuxHandlershouldn't immediately close the Stream for writing (by issuingFINframe) and discarding the write buffer.It should rather mark the Stream as closed for writing and wait for the suitable window update(s) to send the remaining data and only then issue a
FINframe.