Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the case when a stream is closed while still having buffered data for write #330

Merged
merged 8 commits into from
Oct 11, 2023
Merged

Fix the case when a stream is closed while still having buffered data for write #330

merged 8 commits into from
Oct 11, 2023

Commits on Oct 9, 2023

  1. * Introduce ByteBufQueue 

    * Add ByteBufQueue tests
* Writing exec path is always through fill/drain buffer
* Adopt/fix existing tests
* Add new test checking correct handling of negative sendWindowSize
    @Nashatyrev
    Nashatyrev committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    d20ea4c View commit details
    Browse the repository at this point in the history

  2. Spotless

    @Nashatyrev
    Nashatyrev committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    7064086 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Fix the case when a stream is closed while still having buffered data… 

    … for write (due to zero sendWindow)
    @Nashatyrev
    Nashatyrev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    077815a View commit details
    Browse the repository at this point in the history

  2. Replace ByteBuf readSlice().retain() with readRetainedSlice()

    @Nashatyrev
    Nashatyrev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2a82335 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactor/yamux-send-buffer' into fix/close-after-buffer… 

    …ed-write
    @Nashatyrev
    Nashatyrev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    3de4389 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/develop' into fix/close-after-bu… 

    …ffered-write

# Conflicts:
#	libp2p/src/main/kotlin/io/libp2p/mux/yamux/YamuxHandler.kt
    @Nashatyrev
    Nashatyrev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b9bf1d7 View commit details
    Browse the repository at this point in the history

  5. Add unit test for close case when outbound data buffered

    @Nashatyrev
    Nashatyrev committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    28048d6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into fix/close-after-buffered-write

    @Nashatyrev
    Nashatyrev authored Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7cd7ea3 View commit details
    Browse the repository at this point in the history