Feature/dns resolver #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using go-multiaddr-dns as a guide.
It's not just Travis :)
Don't want exceptions propagating out of here. We can handle the error case higher up. This is similar to the case where, for example, we request a dns6 resolution on a name which only has an ip4 address. If people need detailed reporting on DNS failures they can investigate afterwards
Nashatyrev
reviewed
Dec 10, 2019
| companion object { | ||
| private val dnsProtocols = arrayOf(Protocol.DNS4, Protocol.DNS6, Protocol.DNSADDR) | ||
|
|
||
| fun resolve(addr: Multiaddr, resolver: Resolver = DefaultResolver): List<Multiaddr> { |
There was a problem hiding this comment.
I would consider asynchronous invocation here (aka CompletableFuture) since the DNS resolution may take a lot of time.
It also may make sense to check what non-blocking DNS resolve solutions exist to make it possible to resolve DNS in parallel without using a lot of threads
There was a problem hiding this comment.
This is something to think about, yes.
There is further work to do around DNS - the dnsaddr protocol, and also how we expose this as a configuration item (eg through the DSL) - so I'll come back and address that then.
shahankhatch
approved these changes
Dec 10, 2019
This was referenced Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements /dns4/hostname and /dns6/hostname resolution, resolving issue #70