Move interop tests outside tests
#308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is moved to the top level package `tests_interop`, to avoid circular dependency, with the dependency moved to `tox`.
mhchia
changed the title
tests
To make `tox -e py37-interop` run.
|
@carver |
|
Interop tests seemed to fail. I will fix it tomorrow. |
carver
approved these changes
Sep 23, 2019
- Use `from_id`, the changed field name in `PSMessage`.
- PR feedbacks
- Add label `test` in `testenv` in tox.ini, to avoid wrong
dispatching an environment's command in the future.
- Use `pytest` over `py.test`.
To be more confident that the stream handler is registered in the daemon.
|
@carver Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is moved to the top level package
tests_interop, to avoid circular dependency, with the dependency onp2pclientmoved totox.Fixes #296 .