Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all deprecated items #3647

Closed
thomaseizinger opened this issue Mar 20, 2023 · 5 comments
Closed

Remove all deprecated items #3647

thomaseizinger opened this issue Mar 20, 2023 · 5 comments
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Milestone
v0.52.0

Comments

@thomaseizinger
Copy link
Contributor

Description

Remove all #[deprecated] items from the codebase.

Doing so is a breaking change, meaning we only want to do this once we cut the next breaking release.

Motivation

Keeping things lean and lower complexity.

Are you planning to do it yourself in a pull request?

Maybe.
@thomaseizinger thomaseizinger added this to the v0.52.0 milestone Mar 20, 2023
@thomaseizinger thomaseizinger added difficulty:easy help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Mar 20, 2023
@umgefahren umgefahren mentioned this issue Mar 29, 2023
Merged
2 tasks
@umgefahren
Copy link
Contributor

umgefahren commented Mar 29, 2023 •
edited

I will take a go at this. I would suggest creating different PRs for each individual sub crate. This way we can merge the removal along with other breaking changes.

Although this is kind of boring work, I'm happy to be back :)

Tracking:

This was referenced Mar 29, 2023
Merged
Merged
Closed
Merged
Merged
mergify bot pushed a commit that referenced this issue May 2, 2023
@umgefahren
chore(mdns): remove deprecated items
30d2c75 
Related: #3647.

Pull-Request: #3699.
@umgefahren umgefahren mentioned this issue May 2, 2023
Merged
2 tasks
mergify bot pushed a commit that referenced this issue May 2, 2023
@umgefahren
chore(identify): remove deprecated items
3e5f643 
Related: #3647.

Pull-Request: #3698.
mergify bot pushed a commit that referenced this issue May 2, 2023
@umgefahren
chore(dcutr): remove deprecated items
cacfb59 
Removes deprecated items from `libp2p-dcutr`.

Related #3647

Pull-Request: #3700.
mergify bot pushed a commit that referenced this issue May 2, 2023
@umgefahren
chore(gossipsub): remove deprecated items
25d1434 
Removes deprecated items from gossipsub and make certain modules crate-private.

Related #3647.

Pull-Request: #3862.
mergify bot pushed a commit that referenced this issue May 2, 2023
@umgefahren
chore(request-response): remove deprecated items
4bd4653 
Related: #3647.

Pull-Request: #3703.
@thomaseizinger thomaseizinger mentioned this issue May 2, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue May 2, 2023
@thomaseizinger
chore(core): remove deprecated upgrades
2d81b99 
Related #3647.

Pull-Request: #3867.
This was referenced May 5, 2023
Merged
Merged
Merged
mergify bot pushed a commit that referenced this issue May 8, 2023
@thomaseizinger
feat(swarm): remove deprecated banning API
b4e724d 
This is replaced by the `libp2p::allow_block_list` module.

Related: #3647.

Pull-Request: #3886.
mergify bot pushed a commit that referenced this issue May 8, 2023
@thomaseizinger
feat(swarm): remove deprecated IntoConnectionHandler
0e36c7c 
This removes the deprecated `IntoConnectionHandler` trait and all its implementations. Consequently, `NetworkBehaviour::new_handler` and `NetworkBehaviour::addresses_of_peer` are now gone and the two `handle_` functions are now required to implement.

Related: #3647.

Pull-Request: #3884.
This was referenced May 8, 2023
Merged
Merged
Closed
mergify bot pushed a commit that referenced this issue May 8, 2023
@thomaseizinger
feat(swarm): remove deprecated connection limits
b8a7684 
Users are encouraged to use `libp2p::connection_limit::Behaviour` which is a one-to-one replacement for this functionality but built as a `NetworkBehaviour`.

Related: #3647.

Pull-Request: #3885.
mergify bot pushed a commit that referenced this issue May 9, 2023
@thomaseizinger
feat(kad): remove deprecated public modules
3165b12 
This patch removes the 3 out of 4 deprecated public modules. I've left `store` for now because we made some mistakes in declaring that. The items within `store` still need to be publicly visible but I haven't yet figured out a good way of exporting / naming them. Thus, I've left that to a follow-up PR.

Related: #3647.

Pull-Request: #3896.
mergify bot pushed a commit that referenced this issue May 9, 2023
@thomaseizinger
feat(yamux): remove deprecated items
3ee1856 
Related: #3647.

Pull-Request: #3897.
mergify bot pushed a commit that referenced this issue May 9, 2023
@umgefahren
chore(ping): remove deprecated items
5a867c8 
Related #3647.

Pull-Request: #3702.
@tcoratger tcoratger mentioned this issue May 15, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue May 15, 2023
@tcoratger
feat(identity): remove deprecated items
3cc6c7e 
Related: #3647.

Pull-Request: #3928.
@tcoratger tcoratger mentioned this issue May 15, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue May 15, 2023
@tcoratger
chore(relay): remove deprecated items
7c64c42 
Related: #3647.

Pull-Request: #3948.
This was referenced May 16, 2023
Merged
Merged
mergify bot pushed a commit that referenced this issue May 23, 2023
@tcoratger
feat(transports): remove deprecated items in tcp
ccb6e95 
Related: #3647.

Pull-Request: #3978.
@Harshil-Jani
Copy link

Hey guys !! Any estimate about when the 0.52.0 version will be released ? We are eagerly waiting to see it coming since the project on which I am working has some dependency mismatch with matrix-sdk and the only way we can get through this normally is to wait till libp2p 0.52.0 is released.

@thomaseizinger
Copy link
Contributor Author

Hey guys !! Any estimate about when the 0.52.0 version will be released ? We are eagerly waiting to see it coming since the project on which I am working has some dependency mismatch with matrix-sdk and the only way we can get through this normally is to wait till libp2p 0.52.0 is released.

We are aiming to release within the next week, latest early June.

mergify bot pushed a commit that referenced this issue May 24, 2023
@tcoratger
feat(swarm): remove deprecated items
6329d74 
Related: #3647.

Pull-Request: #3956.
mxinden added a commit to mxinden/rust-libp2p that referenced this issue Jun 6, 2023
@mxinden
chore(kad): remove deprecated record
7f33cb0 
Deprecated in libp2p#3738

Deprecation released with `v0.51.3`.

Follow up to libp2p#3896

Part of libp2p#3647
@mxinden mxinden mentioned this issue Jun 6, 2023
Merged
4 tasks
This was referenced Jun 6, 2023
Merged
Merged
mergify bot pushed a commit that referenced this issue Jun 6, 2023
@thomaseizinger
feat(libp2p): remove quic and webrtc re-export
23d499b 
These two re-exports are deprecated because they are both in alpha status. Users should depend on them directly.

Related: #3647.

Pull-Request: #4041.
mergify bot pushed a commit that referenced this issue Jun 6, 2023
@thomaseizinger
feat(core): remove deprecated identity module
6112871 
Related: #3647.

Pull-Request: #4040.
@mxinden
Copy link
Member

mxinden commented Jun 8, 2023

@thomaseizinger, I assume that we don't need to hold the upcoming release for any remaining deprecation-removals. Please correct me if I'm wrong.

@thomaseizinger
Copy link
Contributor Author

@thomaseizinger, I assume that we don't need to hold the upcoming release for any remaining deprecation-removals. Please correct me if I'm wrong.

Nope, no need! I think apart from the record module in kademlia, all other deprecation warnings are actually unreleased.

mergify bot pushed a commit that referenced this issue Oct 25, 2023
@mxinden
chore(kad): remove deprecated module record
4378722 
Deprecated in #3738.
Follow up to #3896.
Part of #3647.

Pull-Request: #4035.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted
Projects
None yet
Milestone
v0.52.0
Development

No branches or pull requests
4 participants
@thomaseizinger @mxinden @umgefahren @Harshil-Jani