-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ping): remove deprecated items #3702
chore(ping): remove deprecated items #3702
Conversation
This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏 |
This pull request has merge conflicts. Could you please resolve them @umgefahren? 🙏 |
We've now opened the merge window for breaking changes so this is good to go in once the merge conflicts are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
Can you fix the rustdoc issues? Thanks! |
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Description
Related #3647.
Notes & open questions
Should be merged with next braking change to libp2p-ping.
Change checklist