WIP: Join multicast group on all interfaces #1750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskimor
changed the title
|
Turns out younger me was right, query socket needs fixing as well. |
|
Depending on all of Are there any smaller crates out there offering the same functionality? |
|
Thanks @mxinden! I believe so, I am currently investigating multicast-socket, which actually does exactly what we need and does not rely on pnet. Looks promising so far. |
eskimor
force-pushed
the
rk-issue-1518
branch
2 times, most recently
from
e0e46da
to
68d95a9
Compare
This avoids duplicate symbols when all features are enabled.
for async_std. tokio does not work yet on Windows, due to missing implementation of as_raw_handle.
Have tokio variant and async-std variant of `set_multicast_if_v4` be named differntly and pass the name in into the code generation macro for the mdns service.
pnet is apparently rather hard to build on windows and get-if-addrs is no longer maintained. Replace both with now maintained if-addrs.
Also factored out networking code in its own module and started a test suite.
|
I believe this is already done now as part of #1830. Feel free to open new issues if the approach taken there seems inadequate or incorrect to you. |
|
Looks good to me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1518.
We now join the multicast group on all interfaces, instead of just the default interface. This definitely fixes the node discovery for me. Initially I mentioned that there is also a problem with the
query_socket, but I don't think this is true (it does not make sense and everything seems to work with this change). Nevertheless I will do some more testing on Monday and provide an additional PR for that problem if need be.