protocols/kad: Extend emitted events with basic information #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In combination with #2063 this can be used to generate the following Grafana graphs.
More to come. |
|
Marked as ready for review. Anyone out there got some time for a review? Maybe @thomaseizinger? |
thomaseizinger
approved these changes
Jun 27, 2021
protocols/kad/src/behaviour.rs
Outdated
| // Note on the difference between 'request' and 'query': A request is a | ||
| // single request-response style exchange with a single remote peer. A query | ||
| // is made of multiple requests across multiple remote peers. | ||
| InboundRequest { |
There was a problem hiding this comment.
The name of this variant is not very "eventy" because it doesn't contain a verb and hence doesn't really express, what happened.
What about InboundRequestServed? That would also include the information you've packed into the docs.
protocols/kad/src/behaviour.rs
Outdated
| }, | ||
|
|
||
| /// An outbound query has produced a result. | ||
| OutboundQueryResult { |
There was a problem hiding this comment.
This one could be named OutboundQueryCompleted or OutboundQueryFinished in the same spirit.
Changed. Thanks for the input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for users of
libp2p-kadto gain deeper insights into the current state of the local DHT this pull request extends the events emitted bylibp2p-kadwith the information below. This is e.g. useful for #2063.protocols/kad: Expose whether routing update is new peer
Can e.g. be used to count the number of peers in the routing table.
protocols/kad: Expose inbound request information
Can e.g. be used to count the arrival rate of new records to be stored in the record store.
protocols/kad: Expose kbucket range on RoutingUpdated
Can e.g. be used to construct a graph of the current kbucket routing table state.