protocols/rendezvous: Improve examples #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add support for the `Identify` protocol to the server, such that the `register_with_identify` example works as intended * Add discovery loop to the `discovery` example and demonstrate cookie usage
|
is mxinden still the only one with write access to the repo? maybe it's time to add @thomaseizinger |
Thanks for the nomination! There is an ongoing discussion about becoming a maintainer, should be sorted once @mxinden comes back from vacation! |
dvc94ch
approved these changes
Sep 16, 2021
|
|
||
| loop { | ||
| tokio::select! { |
There was a problem hiding this comment.
futures::select would be more generic, presumably this is just a reexport
There was a problem hiding this comment.
It is not, the implementation is in fact very different: tokio-rs/tokio@8cf98d6
There was a problem hiding this comment.
It's in my toolbox right now. Didn't bother trying to be runtime agnostic, as the example already used stuff from tokio.
mxinden
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identifyprotocol to the server, such that theregister_with_identifyexample works as intendeddiscoveryexample and demonstrate cookieusage