Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples): change autonat example from async-std to tokio #4574

Merged
merged 3 commits into from
Oct 1, 2023
Merged

refactor(examples): change autonat example from async-std to tokio #4574

merged 3 commits into from
Oct 1, 2023

Conversation

Dejiah
Copy link
Contributor

@Dejiah Dejiah commented Sep 30, 2023 •
edited by thomaseizinger

Description

Changed the autonat example to use tokio instead of async-std as runtime.

Related: #4449.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

thomaseizinger
thomaseizinger approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomaseizinger
Copy link
Contributor

Weirdly enough, the rustsec error appears again. Can you run the suggested cargo update -p webpki command?

@Dejiah
Copy link
Contributor Author

Dejiah commented Oct 1, 2023

Sure, done! 👍

@mergify mergify bot merged commit c86d111 into libp2p:master Oct 1, 2023
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dejiah @thomaseizinger