Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer tokio runtime everywhere #4449

Open
Tracked by #3515
thomaseizinger opened this issue Sep 5, 2023 · 0 comments
Open
Tracked by #3515

Prefer tokio runtime everywhere #4449

thomaseizinger opened this issue Sep 5, 2023 · 0 comments
Labels
difficulty:easy help wanted priority:nicetohave

Comments

@thomaseizinger
Copy link
Contributor

Description

Historically, examples and tests in rust-libp2p have used a mix of the async-std and tokio runtime. These days, both runtimes are equally well supported by the library but the examples and tests are still mixed. For now, we want to keep supporting async-std but all examples and tests should use the tokio runtime.

Motivation

The tokio runtime is much more well established and better maintained. Users should be able to use other runtimes or bring their own.

Current Implementation

Both runtimes are being mixed.
@mxinden mxinden mentioned this issue Sep 6, 2023
Merged
4 tasks
@thomaseizinger thomaseizinger mentioned this issue Sep 20, 2023
Open
@randommm randommm mentioned this issue Sep 21, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Sep 23, 2023
@randommm
refactor(examples): change chat from async-std to tokio
b4d9e52 
Related: #4449.

Pull-Request: #4539.
@thomaseizinger thomaseizinger mentioned this issue Sep 28, 2023
Merged
4 tasks
@arpankapoor arpankapoor mentioned this issue Sep 28, 2023
Merged
4 tasks
@Dejiah Dejiah mentioned this issue Sep 30, 2023
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Oct 1, 2023
@Dejiah
refactor(examples): change autonat example from async-std to tokio
c86d111 
Changed the `autonat` example to use `tokio` instead of `async-std` as runtime.

Related: #4449.

Pull-Request: #4574.
mergify bot pushed a commit that referenced this issue Oct 3, 2023
@arpankapoor
refactor(examples): change ping from async-std to tokio
399eaa3 
Related: #4449.

Pull-Request: #4570.
This was referenced Oct 4, 2023
Merged
Merged
mergify bot pushed a commit that referenced this issue Oct 4, 2023
@randommm
refactor(examples): change ipfs-private from async-std to tokio
0e94bc2 
Related: #4449.

Pull-Request: #4591.
mergify bot pushed a commit that referenced this issue Oct 5, 2023
@randommm
refactor(examples): change ipfs-kad from async-std to tokio
246acfd 
Related: #4449.

Pull-Request: #4590.
This was referenced Feb 24, 2024
Closed
Merged
mergify bot pushed a commit that referenced this issue Feb 29, 2024
@bklaing2
refactor(examples): change file-sharing from async-std to tokio
cc29860 
Closes: #5180
Related: #4449.

Pull-Request: #5191.
guillaumemichel pushed a commit that referenced this issue Mar 28, 2024
@bklaing2 @guillaumemichel
refactor(examples): change file-sharing from async-std to tokio
bbfac65 
Closes: #5180
Related: #4449.

Pull-Request: #5191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:easy help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomaseizinger