Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump yamux from 0.12.0 to 0.12.1 #4930

Merged
merged 4 commits into from
Nov 27, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 27, 2023

Bumps yamux from 0.12.0 to 0.12.1.

Release notes

Sourced from yamux's releases.

yamux-v0.12.1

See changelog for details.

Changelog

Sourced from yamux's changelog.

0.12.1

  • Deprecate WindowUpdateMode::OnReceive. It does not enforce flow-control, i.e. breaks backpressure. Use WindowUpdateMode::OnRead instead. See [PR #177](libp2p/rust-yamux#177).
Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps [yamux](https://github.com/paritytech/yamux) from 0.12.0 to 0.12.1.
- [Release notes](https://github.com/paritytech/yamux/releases)
- [Changelog](https://github.com/libp2p/rust-yamux/blob/master/CHANGELOG.md)
- [Commits](libp2p/rust-yamux@yamux-v0.12.0...yamux-v0.12.1)

---
updated-dependencies:
- dependency-name: yamux
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Nov 27, 2023
@mergify mergify bot merged commit dfce3cc into master Nov 27, 2023
71 checks passed
@mergify mergify bot deleted the dependabot/cargo/yamux-0.12.1 branch November 27, 2023 12:33
@@ -231,7 +231,9 @@ impl WindowUpdateMode {
/// > size must be tuned appropriately for the desired
/// > throughput and level of tolerance for (temporarily)
/// > slow receivers.
#[deprecated(note = "Use `WindowUpdateMode::on_read` instead.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of having the entire WindowUpdateMode struct if it has only one option? Shouldn't it be deprecated entirely?

@@ -1,3 +1,10 @@
## 0.45.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxinden You forgot to bump the version in Cargo.toml for this. CI didn't catch it because this check is disabled for dependency upgrades as we don't want to bump the version for dependencies by default.

mergify bot pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code send-it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants