add type and conversion methods #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmonday
reviewed
Oct 24, 2018
pnet_base/src/macaddr.rs
Outdated
| pub const ETHER_ADDR_LEN: usize = 6; | ||
|
|
||
| /// Structure of a 48-bit Ethernet address. | ||
| pub type EtherAddr = [u8; ETHER_ADDR_LEN]; |
There was a problem hiding this comment.
I don't think this should be public - we don't expose anything else similar to this.
|
Hi, Really sorry it has taken so long to get back to you on these changes. I think most of it looks fine - there are a couple of things I'm not sure about that I have left comments on. FYI The best place to chase me if I don't get back to you is on IRC - I check it more regularly than my swamped inbox! |
|
Welp. Took a really long time again. Sorry! This looks good now, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.