Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NULL pointer dereference in ignore_ip.cpp line 151 #24

Closed
mulander opened this issue Apr 18, 2016 · 0 comments
Closed

NULL pointer dereference in ignore_ip.cpp line 151 #24

mulander opened this issue Apr 18, 2016 · 0 comments

Comments

@mulander
Copy link
Contributor

Hi,

Qt5 started to use libproxy and this exposed a crashing bug on OpenBSD when using Qt5 applications on Gnome 3.

Here's a sample backtrace: https://gist.github.com/mulander/c03997ae7e3fe4e30af0d4f2ce2965f0

The issue is caused by an unguarded dereference in https://github.com/libproxy/libproxy/blob/master/libproxy/modules/ignore_ip.cpp#L151

Other parts of the code properly expect that sockaddr_from_string might return null and guard against it.

Adding a proper guard prevents a segfault both in OpenBSD www/otter-browser and devel/zeal.

I will follow up with a pull request containing the suggested fix.

Regards,
Adam
@mulander mulander mentioned this issue Apr 18, 2016
Closed
DimStar77 added a commit that referenced this issue Apr 28, 2016
@DimStar77
Merge pull request #25 from mulander/fix-null-deref-in-ignore-ip
59bc765 
Fix #24 NULL pointer dereference in ignore_ip.cpp line 151
bluerise pushed a commit to bitrig/bitrig-ports that referenced this issue May 4, 2016
Add a patch to prevent a null pointer dereference in net/libproxy und…
4b6f0f9 
…er Gnome

Qt5 started to use libproxy and this exposed a crashing bug on OpenBSD
when using Qt5 applications on Gnome 3.

Here's a sample backtrace:
https://gist.github.com/mulander/c03997ae7e3fe4e30af0d4f2ce2965f0

The issue is caused by an unguarded dereference of ign_ip.

Other parts of the code properly expect that sockaddr_from_string
might return null and guard against it.

Adding a proper guard prevents a segfault both in OpenBSD
www/otter-browser and devel/zeal.

Issue reported upstream in:
 libproxy/libproxy#24

OK zhuk@ aja@

Written by: awolk <awolk@cvs.openbsd.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mulander