bindings: perl: Add an option to explicitly link against libperl.so. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Perl binding uses symbols from libperl.so, but since it is always run after libperl.so itself is loaded, not linking against it does not cause the problems that would normally occur. Doing so was mandatory since 5077b75 ("bindings: perl: Do not link against libperl"), which was catering for distros which install the binding into vendor_perl and try not to rebuild all their Perl packages on every Perl update. The flip-side is that it breaks things for other groups: distros that install the binding into a versioned Perl directory and allow different Perl versions to be installed concurrently (for example, FreeBSD), or distros that pass "--no-undefined" to the linker. Provide an option, PERL_LINK_LIBPERL (whose default depends on the value of PERL_VENDORINSTALL), to make the behavior configurable.
|
👍 No idea what happened to Travis again... |
DimStar77
added a commit
that referenced
this pull request
Jan 20, 2016
bindings: perl: Add an option to explicitly link against libperl.so.
janbrummer
added a commit
to janbrummer/libproxy
that referenced
this pull request
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Perl binding uses symbols from libperl.so, but since it is always
run after libperl.so itself is loaded, not linking against it does not
cause the problems that would normally occur.
Doing so was mandatory since 5077b75 ("bindings: perl: Do not link
against libperl"), which was catering for distros which install the
binding into vendor_perl and try not to rebuild all their Perl packages
on every Perl update. The flip-side is that it breaks things for other
groups: distros that install the binding into a versioned Perl
directory and allow different Perl versions to be installed
concurrently (for example, FreeBSD), or distros that pass
"--no-undefined" to the linker.
Provide an option, PERL_LINK_LIBPERL (whose default depends on the value
of PERL_VENDORINSTALL), to make the behavior configurable.