Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move glib2 inclusion out of c++ protection. #227

Merged
merged 1 commit into from May 22, 2023

Conversation

0-wiz-0
Copy link
Contributor

@0-wiz-0 0-wiz-0 commented May 22, 2023

Fixes usage of header file from C++.

Addresses one part of #226.

Fixes usage of header file from C++.

Addresses one part of libproxy#226.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (383681b) 71.63% compared to head (55ad54a) 71.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files          17       17           
  Lines         825      825           
  Branches      220      220           
=======================================
  Hits          591      591           
  Misses        140      140           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@janbrummer
Copy link
Contributor

Thanks, for the next PR please leave out the dot at the subject line.

@janbrummer janbrummer merged commit d32f1e6 into libproxy:main May 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants