Fix race condition in px_manager_get_proxies_sync #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concurrenct access in px_manager_get_proxies_sync leads to random crashes in duktape. Limit it to one access at a time as has been done in previous releases.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 69.58% 69.75% +0.17%
==========================================
Files 17 17
Lines 868 873 +5
Branches 239 239
==========================================
+ Hits 604 609 +5
Misses 160 160
Partials 104 104
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concurrenct access in px_manager_get_proxies_sync leads to random crashes in duktape. Limit it to one access at a time as has been done in previous releases.