Reread env variables in each get_config call #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications using libproxy can set environment variables during their runtime to influence the behaviour of libproxy. One prominent example is glib-pacrunner. Let's change it back to the flow used in 0.4 releases.
janbrummer
force-pushed
the
env-always-get
branch
from
a2a2b23
to
46b1dd9
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
==========================================
- Coverage 69.75% 69.06% -0.70%
==========================================
Files 17 16 -1
Lines 873 863 -10
Branches 239 239
==========================================
- Hits 609 596 -13
- Misses 160 161 +1
- Partials 104 106 +2
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications using libproxy can set environment variables during their runtime to influence the behaviour of libproxy. One prominent example is glib-pacrunner. Let's change it back to the flow used in 0.4 releases.