Specify library version more completely #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the library version is not specified, meson installs the shared object using only the soversion, and this causes ldconfig to emit a warning that the shared object is not a symlink. Specifying a version that matches the project version means that version is used for the shared object, and the soversion-named file is then a symilnk to that, which is common across other libraries, and avoids the warning from ldconfig. https://bugzilla.redhat.com/show_bug.cgi?id=2247508
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 73.15% 73.15%
=======================================
Files 16 16
Lines 842 842
Branches 238 238
=======================================
Hits 616 616
Misses 131 131
Partials 95 95 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the library version is not specified, meson installs the shared object using only the soversion, and this causes ldconfig to emit a warning that the shared object is not a symlink. Specifying a version that matches the project version means that version is used for the shared object, and the soversion-named file is then a symilnk to that, which is common across other libraries, and avoids the warning from ldconfig.
https://bugzilla.redhat.com/show_bug.cgi?id=2247508