Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the correct separator character for Windows ProxyOverride #263

Merged
merged 1 commit into from Dec 14, 2023

Conversation

davids-work
Copy link
Contributor

The ProxyOverride entries are separated by semicolons, not by commas

proxy-config-uri proxy-config-registry

@janbrummer
Copy link
Contributor

Good catch, thank you!

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42b58ef) 73.15% compared to head (03dbf4e) 73.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #263   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files          16       16           
  Lines         842      842           
  Branches      238      238           
=======================================
  Hits          616      616           
  Misses        131      131           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janbrummer janbrummer merged commit 9b541a5 into libproxy:main Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants