Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Try all configured proxy resolution types #278

Merged
merged 1 commit into from Mar 6, 2024

Conversation

davids-work
Copy link
Contributor

On Windows, WPAD, PAC and manual proxy settings are not mutually exclusive. They can all be set and should be tried in that order.

On Windows, WPAD, PAC and manual proxy settings are not mutually
exclusive. They can all be set and should be tried in that order.
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dff9a60) 72.67% compared to head (a35525a) 72.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   72.67%   72.67%           
=======================================
  Files          16       16           
  Lines         849      849           
  Branches      241      241           
=======================================
  Hits          617      617           
  Misses        137      137           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janbrummer
Copy link
Contributor

libproxy is using a specific configuration logic, and it should be the same among all systems: https://libproxy.github.io/libproxy/configuration-logic.html

@davids-work
Copy link
Contributor Author

davids-work commented Feb 28, 2024

The problem is that this makes libproxy a LOT less useful on Windows. "Automatically detect settings" (the switch that controls whether or not WPAD is used) seems to be turned on by default on many installations, and when/if manual settings are configured, it won't get turned off unless the configurator explicitly does so. This prevents libproxy from picking up the manual proxy settings. I have unfortunately encountered systems configured exactly like this in the wild.

The current behavior of libproxy is different from e.g. Edge or Chrome in this regard (which do try all options if enabled and if necessary). My expectation for a Windows application using system proxy settings would be for it to behave in the same manner as the built-in browser.

For reference, this is what the settings GUI looks like (on Windows 10):
image
Note how all options can be enabled.

@janbrummer
Copy link
Contributor

So we talked about this internally and we agreed to follow the system logic then. Will merge it.

@janbrummer janbrummer merged commit 90693ec into libproxy:main Mar 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants