Separate implementation for DistArray
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't implement copy(), make distcheck errors out at the linking stage. For every mystery, there is someone, somewhere, who knows the truth. Perhaps that someone is watching. Perhaps it's you.
Also fix a bug in the stream operator. I couldn't get it to work outside of the class, so I put it inside the class and made it a friend.
This was referenced Sep 13, 2013
dmcdougall
added a commit
that referenced
this pull request
Sep 16, 2013
Separate implementation for `DistArray`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
DistArrayout of the header, and into its own file,DistArray.C;DistArrayclass. Coverage for the class went from 45% to 88%.