Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Add LibratoBatchBuilder with default values for easier API #31

Closed
wants to merge 5 commits into from
Closed

Add LibratoBatchBuilder with default values for easier API #31

wants to merge 5 commits into from

Conversation

paulwellnerbou
Copy link

See objections in #30

@collinvandyck
Copy link
Contributor

@paulwellnerbou thanks! we'll take a look shortly.

@mheffner
Copy link
Contributor

mheffner commented Nov 2, 2018

We are now tracking the latest client at https://github.com/appoptics/appoptics-api-java.

@mheffner mheffner closed this Nov 2, 2018
@paulwellnerbou
Copy link
Author

@mheffner , @collinvandyck , as I am not using this anymore, I won't spent more time in this pull request. As this did not get merged, I created my own version, which I think has a much more nice API (see #32 as well)
Feel free to use my code. I won't keep my branch up to date for more than two years.

@mheffner
Copy link
Contributor

mheffner commented Nov 2, 2018

Thanks @paulwellnerbou for the explanation. We have actually recently added the OkHttpPoster based on OkHttp as an alternative Poster, as it provided better support for connection reuse and http/2 handling. This reduced the number of "connect failed" attempts we would see from clients reporting frequently since they didn't have to reestablish a new connection each time.

We plan to make this poster the default in the future, we're just ensuring it is completely stable. It sounds like you are not using Librato anymore, but if you have an opportunity to give Librato/AppOptics a try in the future give the OkHttpPoster a shot.

@paulwellnerbou
Copy link
Author

@mheffner, thanks for your answer. The mentioned problem was not the motivation of this pull request.
I reduced the lines of code to use librato (as most users do, I suspect) and made it much more easier, and, at the same time using the Builder, not cutting flexibility.

But maybe that the current API changed in this direction as well. This is a long time ago...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants