Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Inherit Tags #132

Merged
merged 7 commits into from
Jan 24, 2017
Merged

Inherit Tags #132

merged 7 commits into from
Jan 24, 2017

Conversation

chancefeick
Copy link
Contributor

Use :inherit_tags option introduced in librato/librato-rack#65 to inherit default tags (service, environment,host) for automatic instrumentation.

Tag inheritance is also applicable to custom instrumentation. Here’s a few examples:

Librato.increment 'user.signup'
# => {:host=>"ip-10-0-0-4.ec2.internal"}

Librato.increment 'user.signup', tags: { plan: 'developer' }
#=> {:plan=>"developer"}

Librato.increment 'user.signup', tags: { plan: 'developer' }, inherit_tags: true
# => {:host=>"ip-10-0-0-4.ec2.internal", :plan=>"developer"}

Merge into #123. Requires librato/librato-rack#65.

Copy link
Contributor

@nextmat nextmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@chancefeick chancefeick merged commit dcfda5c into feature/md Jan 24, 2017
@chancefeick chancefeick deleted the feature/inherit-tags branch February 7, 2017 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants