Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additions to Next release - v2.8.0 #768

Closed
9 tasks done
IkelAtomig opened this issue Jul 22, 2023 · 8 comments
Closed
9 tasks done

Additions to Next release - v2.8.0 #768

IkelAtomig opened this issue Jul 22, 2023 · 8 comments

Comments

@IkelAtomig
Copy link
Member

IkelAtomig commented Jul 22, 2023


P.S. Things that I noticed in my Radar are listed here. Other open issues will be looked and could be added.

Comments are welcome regarding the features don't like. But open a new issue and reference this one there. To keep it tidy.

@ManeraKai
Copy link
Member

ManeraKai commented Jul 28, 2023

Stick to the default variable when switching frontends for Redirect type in YouTube. Instead of being separate

This is already like that?

@ManeraKai
Copy link
Member

ManeraKai commented Jul 29, 2023

Hide Unsupported iframes handling option for frontends that don't support it.

This option IS for the urls that the frontends don't support.

@IkelAtomig
Copy link
Member Author

Then rename it as URLs when we don't replace embeds for a frontend.

@ManeraKai
Copy link
Member

You still didn't understand it, it was before Unsupported urls handling, but we changed it to Unsupported iframes handling bc it is only for iframes. Say Piped-Material doesn't support iframes, so we need an option to tell LibRedirect to either bypass any youtube iframe or block it entirely, hence Unsupported iframes handling exists.

@IkelAtomig
Copy link
Member Author

Just keep it as iframes handling for YouTube, Twitter and rename as URLs for other frontends. I guess that would make sense and avoid confusion.

@ManeraKai
Copy link
Member

for other frontends they may have iframes too, and the option doesn't do anything other than iframes my man.

@IkelAtomig
Copy link
Member Author

Well, it could be reused then. For example, IMDb frontend still doesn't support few URLs such as Movie company info - https://imdb.com/company/co0485456?ref_=tt_dt_co_1. For these, when we set it to bypass, it loads IMdb or loads libremdb when set to block. That is how it should function.

If renamed as unsupported URLs handling. But in the case of iframes, only YouTube, Twitter, Imgur, Reddit and possibly, Bandcamp has iframes. So, either hide it for other frontends or rename it.

@ManeraKai
Copy link
Member

#648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants