Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Redirect (frontend) to Prefferred" by a new implementation #767

Closed
Victor239 opened this issue Jul 22, 2023 · 12 comments
Closed

Add "Redirect (frontend) to Prefferred" by a new implementation #767

Victor239 opened this issue Jul 22, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@Victor239
Copy link

I've got bookmarks for webpages on Teddit instances, as well as RSS feeds from various instances also. Often when I visit these webpages now I find the content doesn't load due to a 429 error e.g. https://teddit.zaggy.nl/r/AskReddit.

I've now switched over to using localhost instance type for Teddit, so it would be helpful if there was a button to Redirect to localhost when visiting a public instance site, if the localhost option is enabled. Right now I have to delete the domain name, type reddit.com and have to redirect to the localhost site.

@IkelAtomig
Copy link
Member

You mean redirect and Redirect to localhost should co-exist in the popup menu ?

@IkelAtomig IkelAtomig added the enhancement New feature or request label Jul 22, 2023
@Victor239
Copy link
Author

Redirect to Original and Redirect to localhost, yes.

@IkelAtomig
Copy link
Member

Got it.

@ManeraKai
Copy link
Member

ManeraKai commented Jul 28, 2023

The solution to that should be this: https://libredirect.github.io/docs.html#preferred_instance. It's already there in Teddit by this small [R↗] button. Though the button isn't there for a subreddit link, just for a post or a comment's link.

@ManeraKai ManeraKai closed this as not planned Won't fix, can't repro, duplicate, stale Jul 28, 2023
@Victor239
Copy link
Author

@ManeraKai that doesn't work on Teddit when there's a 429 error. It's why I made this feature request. See below:

image

@ManeraKai
Copy link
Member

I understand but the solution should be on Teddit's side.
There's a possibility of implementing a button that trusts the user that that link is a teddit instance etc.

@Victor239
Copy link
Author

Unfortunately Teddit is no longer actively maintained so this is not possible.

Other than Teddit there also other frontends (or particular instances) I've found sometimes don't load the pages correctly. I believe this is why frontends_manager was even created, to encourage users to instead utilise their own frontend for increased reliability?

To make it easier to migrate from public instances to localhost versions of websites it would therefore be very useful to have this shortcut, as right now my workflow is:

  1. Visit public instance Teddit post (from bookmark/saved link/RSS), find that it has a 429 error
  2. Copy the URL
  3. Open a new tab
  4. Paste the URL
  5. Delete the domain name segment
  6. Enter the domain name as reddit.com
  7. Submit and be redirected to localhost version

As you might imagine, this is quite tedious. It's also the kind of feature that would be useful across every type of frontend, and for encouraging frontends_manager usage in general, so I believe it should be integrated into LibRedirect itself and not be a frontend-specific feature.

@ManeraKai
Copy link
Member

ManeraKai commented Aug 2, 2023

This feature seems simple but it requires either:

  1. knowing all teddit instances on the internet.
  2. Sending an http request to the current website in tab to see if it's teddit or not (I do that with FediRedirect), though this is bad for privacy if you were dumb and opened the popup on every website.
  3. Have Redirect Teddit to localhost, Redirect Invidious to localhost, Redirect Teddit to Original, Redirect Invidious to Original and to all frontends in the popup and "trust" the user into saying what website it is (this may cause errors if the user was dumb and pressed the wrong frontend).

@Victor239
Copy link
Author

If I visit e.g. https://teddit.net/r/pics/comments/15frx1u/a_stained_glass_transom_i_made/ then when I open the pop-up it looks like LibRedirect already knows I'm on a Teddit instance as it shows the toggle for Reddit at the top.

I presume that it does this by checking the current webpage URL against the list of known public instances that LibRedirect already has access to. So is this data not already available for usage? This way a universal button for Redirect to localhost can be used.

@ManeraKai
Copy link
Member

No LibRedirect is thinking that that URL is a reddit.com url xD

@Victor239
Copy link
Author

Victor239 commented Aug 2, 2023

Ah, I don't quite understand how that works then in relation to the 3 approaches you suggested.

I would have said my preferred approach is what I said there: "checking the current webpage URL against the list of known public instances that LibRedirect already has access to". Not sure if that's possible or not.

Failing that, approach 2 is better than not having a workaround, as long as this feature can be toggled off/on.

@ManeraKai ManeraKai reopened this Aug 2, 2023
@ManeraKai ManeraKai changed the title If using localhost instance type, add a new pop-up link for "Redirect to localhost" when visiting public instances Add "Redirect (frontend) to Prefferred" and Redirect (frontend) to Original" by a new implementation Aug 2, 2023
@ManeraKai
Copy link
Member

image

@ManeraKai ManeraKai changed the title Add "Redirect (frontend) to Prefferred" and Redirect (frontend) to Original" by a new implementation Add "Redirect (frontend) to Prefferred" by a new implementation Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants