Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YT Music being redirected with only 'YouTube' enabled #830

Closed
RyanHx opened this issue Oct 14, 2023 · 11 comments
Closed

YT Music being redirected with only 'YouTube' enabled #830

RyanHx opened this issue Oct 14, 2023 · 11 comments
Labels
enhancement New feature or request

Comments

@RyanHx
Copy link

RyanHx commented Oct 14, 2023

In the extension settings I have YouTube enabled and YT Music disabled, but when I navigate to https://music.youtube.com/ it tries to redirect the page to FreeTube (my setting for YouTube).

I see that on this line the music.youtube.com domain is a target for the standard youtube setting, which seems like a mistake as it's also in the youtubeMusic category in that same file. I'm not sure if removing that line would fix this behaviour or if there's more to how the extension picks up redirect targets, that was just the first thing I found on skimming through.

Running on Firefox 118.0.2 (64-bit), Windows 10.

@ManeraKai
Copy link
Member

This is happening bc of this: #823

@RyanHx
Copy link
Author

RyanHx commented Oct 14, 2023

In that case would it be possible to have the YouTube frontend available in the YT Music specific settings to satisfy that feature request? Since they're seperate categories in the extension it's odd that one setting overrides the other.

@ManeraKai ManeraKai added the enhancement New feature or request label Oct 18, 2023
ManeraKai added a commit that referenced this issue Oct 18, 2023
@RyanHx
Copy link
Author

RyanHx commented Oct 19, 2023

Unfortunately the behaviour remains unchanged with this update; enabling YouTube also redirects Youtube Music even with YT Music disabled - tested with a fresh install of the extension.

@ManeraKai
Copy link
Member

ManeraKai commented Oct 20, 2023

I changed the code but I still didn't release? Do you want to have a test package to try?

@RyanHx
Copy link
Author

RyanHx commented Oct 20, 2023

Sorry, I saw the version bump in one of the adjacent commits so thought it released. I'm happy to test the changes though.

@ManeraKai
Copy link
Member

Here you go: libredirect-2.8.2.zip
Follow the instructions here: Install the zip package on Firefox (temporarily)

@RyanHx
Copy link
Author

RyanHx commented Oct 20, 2023

2.8.2 seems to still be redirecting YT Music - https://music.youtube.com/ opens freetube. Here's a copy of my settings for you to try: libredirect-settings-v2.8.2.json

@ManeraKai
Copy link
Member

I'm stupid sorry: libredirect-2.8.2.zip

@RyanHx
Copy link
Author

RyanHx commented Oct 21, 2023

Cheers, can confirm that release fixes it :)

@RyanHx
Copy link
Author

RyanHx commented Feb 16, 2024

Hey there, I was wondering if we could get this change pushed to the public addon? We still seem to be on 2.8.1 on Firefox with the same behaviour as this original issue. Manually installing the addon via a file I think only lasts for a single session.

@ManeraKai
Copy link
Member

We'll try to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants