Limit oidc check session iframe postMessage hook scope #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases the check session iframe might receive postMessage events from itself. This might sound strange and normally does not happen expect in cases where other scripts run in the scope of this iframe (e.g. getting injected by a browser extension). This for example happens with the 1Password browser extension which seems to communicate with itself via postMessage to itself and causes a high CPU load as an event busy loop is created. With this change, our own processing of events is only done if the event source is not the own window (which is the only case we care about anyways).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases the check session iframe might receive postMessage events from itself. This might sound strange and normally does not happen expect in cases where other scripts run in the scope of this iframe (e.g. getting injected by a browser extension). This for example happens with the 1Password browser extension which seems to communicate with itself via postMessage to itself and causes a high CPU load as an event busy loop is created.
With this change, our own processing of events is only done if the event source is not the own window (which is the only case we care about anyways).