Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate FeaturePeek to be able to review storybook changes easier #257

Open
nicopace opened this issue May 29, 2020 · 5 comments
Open

Comments

@nicopace
Copy link
Member

If we integrate featurepeek we will be able to see how each PR looks like from the github interface without having to download and build the code, streamlining the review process.

@nicopace
Copy link
Member Author

Here you can see a quick recap of what it enables: https://dashboard.featurepeek.com/peek/237hv52#/0

@ilario
Copy link
Member

ilario commented Jun 5, 2020

In lime-packages a similar thing is being done using Travis:

https://github.com/libremesh/lime-packages/blob/3e11bd142d9b7cbb58bd5bea6d0bac906484dcca/.travis.yml#L63-L65

in which each PR gets compiled and published on a server (which in the lime-packages case is https://snapshots.libremesh.org/branches which is not working).

@germanferrero
Copy link
Contributor

@nicopace we tried it, but featurepeek requests permission over private repositories.
Wich is too much for @spiccinini and me:
Imagen Pegada el 2020-8-5 16-56

We are exploring own hosted solutions :)

@nicopace
Copy link
Member Author

nicopace commented Aug 5, 2020

It looks like private repositories are optional... it is in yellow... isn't there any chance to disable that? (clicking on the yellow thingy)

@spiccinini
Copy link
Contributor

spiccinini commented Aug 5, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants