-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
angw, lime-proto-bmx7: use nft includes instead of init.d scripts #1021
Conversation
see also: #1020 I tested it on an archer c7 and it seems working:
We may want to remove the counters after we verified that everything is working as intended. |
Very good work, thank you! |
Good work, a few questions can't we use either use |
If we put the scripts in I just found out that firewall4 will add duplicates of the inlcuded rules outside |
Now, both |
I just don't like maybe a good directory could be |
What about having the files shipped by the package in |
I think this would be confusing, because putting the files there would suggest that they are automatically included, like the files in i.e. I prefer |
Maybe squash the commits so it looks nice in lime-packages git history. But apart from that I think this is ready to go in. |
…bles, use nft include instead, fix bmx7 not over bat0, update dependencies
272c89f
to
758a26b
Compare
Using
/etc/init.d
-scripts for making nftable / xtable rules can lead to problems. See this comment: #1020 (comment) .This PR removes the
/etc/init.d/
-script for anygw and places nft-rules in/etc/firewall.lime.d/
. It also places the bmx7-not-over-bat0 rule there. The rules were rewritten nft-compatible, so that they can be included in the firewall config. It makes anygw andlime-proto-bmx7
compatible tofirewall4
andnftables
, without usingebtables-nft
.lime-proto-bmx7
andlime-proto-anygw
are now explicitly dependant onfirewall4
, not implicitly vialime-system
like before. A fallback for the mtu-fix inlime-proto-bmx7
for when no firewall package is installed is no longer necessary and was removed.