-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add shared state async node #1030
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1030 +/- ##
==========================================
+ Coverage 77.84% 79.28% +1.44%
==========================================
Files 52 53 +1
Lines 4388 4447 +59
==========================================
+ Hits 3416 3526 +110
+ Misses 972 921 -51
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change would silently break other components using that data like lime app, and anyway is unrelated to the PR, let's keep it out.
# Source settings (i.e. where to find the source codes) | ||
# This is a custom variable, used below | ||
# disable git package source and enable Build/Prepare line 29-30 | ||
# SOURCE_DIR:= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block should be removed as source tree override should be used for that purpose as explained by Jow here https://forum.archive.openwrt.org/viewtopic.php?id=46916
This is a proposal to implement an improvement on current shared state base infrastructure.