Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleaning #1037

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Small cleaning #1037

merged 3 commits into from
Oct 4, 2023

Conversation

G10h4ck
Copy link
Member

@G10h4ck G10h4ck commented Jul 28, 2023

Change package maintainer, correct license, plus comment on the code

@ilario
Copy link
Member

ilario commented Jul 31, 2023

Can the title "provides data-type for user marked reliable network nodes" be more clear?

Can you add the description? Before merging?

Is German Ferrero part of Altermundi? I mean, why replacing his name instead of adding a new line?

@G10h4ck
Copy link
Member Author

G10h4ck commented Aug 17, 2023

Can the title "provides data-type for user marked reliable network nodes" be more clear?

Nope, it is exactly what that package does.

Is German Ferrero part of Altermundi? I mean, why replacing his name instead of adding a new line?

He was, and that contribution was as part of it's Altermundi participation, now Altermundi is keeping on the maintenance of this package.

@ilario
Copy link
Member

ilario commented Sep 20, 2023

Ok, can you add the description?

@G10h4ck
Copy link
Member Author

G10h4ck commented Oct 4, 2023

Ok, can you add the description?

done

@ilario
Copy link
Member

ilario commented Oct 4, 2023

Ok, can you add the description?

done

Did you push?
Right now I can still see only a TODO as the description.

@codecov-commenter
Copy link

Codecov Report

Merging #1037 (cc6738b) into master (bf158a1) will increase coverage by 0.40%.
Report is 85 commits behind head on master.
The diff coverage is 100.00%.

❗ Current head cc6738b differs from pull request most recent head 6e909d1. Consider uploading reports for the commit 6e909d1 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master    #1037      +/-   ##
==========================================
+ Coverage   79.27%   79.67%   +0.40%     
==========================================
  Files          53       53              
  Lines        4444     4542      +98     
==========================================
+ Hits         3523     3619      +96     
- Misses        921      923       +2     
Files Coverage Δ
...ages/lime-system/files/usr/lib/lua/lime/config.lua 97.72% <100.00%> (+0.03%) ⬆️
...ges/lime-system/files/usr/lib/lua/lime/network.lua 78.39% <100.00%> (+0.20%) ⬆️
...kages/lime-system/files/usr/lib/lua/lime/utils.lua 85.51% <ø> (+0.28%) ⬆️
...tuck-wa/files/usr/lib/lua/lime/wifi_unstuck_wa.lua 100.00% <100.00%> (ø)
tests/fakes/iwinfo.lua 98.13% <100.00%> (+1.02%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ilario
Copy link
Member

ilario commented Oct 4, 2023

Thanks. With the new phrasing, also the title is muuuch more clear!

@ilario ilario merged commit 9f8754b into libremesh:master Oct 4, 2023
1 check passed
@G10h4ck G10h4ck added this to the mesh-wide milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants