Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a repetition in lime-defaults-factory #552

Merged
merged 1 commit into from Jul 29, 2019
Merged

Remove a repetition in lime-defaults-factory #552

merged 1 commit into from Jul 29, 2019

Conversation

ilario
Copy link
Member

@ilario ilario commented Jul 25, 2019

No description provided.

@gmarcos87
Copy link
Contributor

gmarcos87 commented Jul 28, 2019 •
edited

Hi @ilario, how is mtu set by default in bmx6?

@spiccinini
Copy link
Contributor

@gmarcos87 It is repeated, it is in the lines 19 and 34 and ilario is removing the first ocurrence.

@ilario
Copy link
Member Author

ilario commented Jul 29, 2019

@gmarcos87 as @spiccinini pointed out, the setting of bmx6_mtu is still present in the modified file, I just removed a line where it got set another time.

@gmarcos87 gmarcos87 self-requested a review July 29, 2019 13:30
@gmarcos87 gmarcos87 merged commit 047520f into libremesh:master Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiccinini spiccinini spiccinini approved these changes

@gmarcos87 gmarcos87 gmarcos87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ilario @gmarcos87 @spiccinini